Skip to content

fix typo, it said sawtooth, it should say sine #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix typo, it said sawtooth, it should say sine #2241

merged 1 commit into from
Oct 21, 2024

Conversation

montoyamoraga
Copy link
Contributor

later in the tutorial the sawtooth wave is used.

What This PR Changes

  • it changes a mention of sawtooth wave, for sine wave, which is what it meant, it was a typo.

Contribution Guidelines

@montoyamoraga
fix typo, it said sawtooth, it should say sine
2681f35 
later in the tutorial the sawtooth wave is used.
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@g-castronovo
Copy link
Contributor

@jacobhylen since you're the original author, I need to ask you: I am not sure is a typo. what kind of curve shows the progenerated code?

@jacobhylen
Copy link
Contributor

Hello @g-castronovo
@montoyamoraga is correct, there was indeed a typo introduced at some point.
We should also change the comment in the code example here that also says sawtooth.

@g-castronovo g-castronovo added fix/update A small fix or update community Bugs and fixes suggested by the community maker labels Oct 15, 2024
karlsoderby
karlsoderby approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this typo @montoyamoraga , looks good to me.

@karlsoderby karlsoderby merged commit fa0d46f into arduino:main Oct 21, 2024
5 checks passed
@montoyamoraga montoyamoraga deleted the patch-1 branch October 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlsoderby karlsoderby karlsoderby approved these changes

Assignees

No one assigned

Labels

community Bugs and fixes suggested by the community fix/update A small fix or update maker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@montoyamoraga @CLAassistant @g-castronovo @jacobhylen @karlsoderby